Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGX nmcli for netvm #792

Merged
merged 1 commit into from
Sep 24, 2024
Merged

AGX nmcli for netvm #792

merged 1 commit into from
Sep 24, 2024

Conversation

emrahbillur
Copy link
Contributor

@emrahbillur emrahbillur commented Sep 17, 2024

Description of changes

Changes in NetVm for Lenovo left the state of NetVm in NVIDIA AGX behind where there was no NetworkManager tool to create a connection. The passthrough for Wifi device was active but there were no means of creating a wireless connection. NX had no problems as the netvm utilizes the ethernet device. Here this PR adds NetworkManager and nmcli to the netvm on NVIDIA AGX devices to allow networkmanager to connect to wireless network.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to: Jetson Orin AGX - aarch64
  • Is this a new feature
    • List the test steps to verify:
  1. Run nmcli to check the connections listing wlp0s5f0 (wifi device) disconnected.
  2. Run nmcli con to ensure there is no wifi connection but only loopback.
NAME  UUID                                  TYPE      DEVICE 
lo    9fe4bd21-f68d-4df6-8537-ab2edba3d9ed  loopback  lo  
  1. Run nmcli d wifi list to get a list of Wireless Access Points
IN-USE  BSSID              SSID                        MODE   CHAN  RATE        SIGNAL  BARS  SECURITY 
        AA:BB:CC:DD:EE:11  SomeSSID_unknwn 2,4GHz      Infra  11    195 Mbit/s  79      ▂▄▆_  WPA2    
  1. Run nmcli dev wifi con "SomeSSID_unknwn" --ask to start Wifi connection and being asked its Wireless password.
Password: ***********
Device 'wlp0s5f0' successfully activated with 'c15e0916-bde5-44e8-fbfb-4860dd0b89da'.
  1. Run nmcli con again to verify connection.
NAME               UUID                                  TYPE      DEVICE 
SomeSSID_unknwn    c15e0916-bde5-44e8-fbfb-4860dd0b89da  wifi      wlp0s5f0
lo                 9fe4bd21-f68d-4df6-8537-ab2edba3d9ed  loopback  lo  
  1. Run ping 8.8.8.8 to check ip connectivity
PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.
64 bytes from 8.8.8.8: icmp_seq=1 ttl=59 time=9.65 ms
64 bytes from 8.8.8.8: icmp_seq=2 ttl=59 time=8.58 ms
^C
--- 8.8.8.8 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 1001ms
rtt min/avg/max/mdev = 8.575/9.113/9.652/0.538 ms
  • If it is an improvement how does it impact existing functionality?
    Without this PR the netvm on AGX had no wireless connection capability.
    Unfortunately the NetworkManager caused cross compile failure.

@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 17, 2024 12:02 — with GitHub Actions Inactive
@emrahbillur emrahbillur self-assigned this Sep 17, 2024
@emrahbillur emrahbillur added the bug on Orin AGX Issues found on NVIDIA Jetson AGX Orin while checking this PR label Sep 17, 2024
@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 17, 2024 12:05 — with GitHub Actions Inactive
@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 17, 2024 12:05 — with GitHub Actions Inactive
@emrahbillur emrahbillur marked this pull request as draft September 18, 2024 05:37
@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 18, 2024 14:09 — with GitHub Actions Inactive
@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 18, 2024 14:11 — with GitHub Actions Inactive
@emrahbillur emrahbillur temporarily deployed to internal-build-workflow September 18, 2024 14:14 — with GitHub Actions Inactive
@emrahbillur emrahbillur marked this pull request as ready for review September 19, 2024 07:40
@emrahbillur emrahbillur removed the bug on Orin AGX Issues found on NVIDIA Jetson AGX Orin while checking this PR label Sep 19, 2024
Remove unwanted visual NeworkManager plugins preventing cross compilation
Added nmcli to netvm
Wifi Module Addded


Signed-off-by: Emrah Billur <[email protected]>
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Sep 23, 2024
@leivos-unikie
Copy link
Contributor

Tested on Orin AGX

  • After flashing Orin AGX the described tests work fine and ci-test-automation passes with native build
  • With cross-compiled build ssh to net-vm does not succeed after it has been restarted

@leivos-unikie leivos-unikie added Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin and removed Needs Testing CI Team to pre-verify labels Sep 23, 2024
@brianmcgillion brianmcgillion merged commit eb760c7 into tiiuae:main Sep 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Orin AGX This PR has been tested on NVIDIA Jetson AGX Orin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants